phy: marvell: Cannot test unsigned field to be negative
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Wed, 6 Aug 2025 16:43:25 +0000 (17:43 +0100)
committerJerome Forissier <jerome.forissier@linaro.org>
Mon, 18 Aug 2025 12:08:57 +0000 (14:08 +0200)
commit2e9155cb9f366a6b9191af0850efad1948b4c785
tree5346508158201e2e0565aa9a9518ee69bd68003b
parenta75c8a4b883108edf19127fca3e6c6c590f9ba8c
phy: marvell: Cannot test unsigned field to be negative

In comphy_cp110_init_serdes_map in comphy_cp110.c there are two fields
in cfg, comphy_lanes_count and comphy_mux_bitcount, which are fetched
from the FDT blob with fdtdec_get_int which returns an int. These two
fields are then tested for being negative. However the fields are
declared as unsigned so those tests must always fail. Change the
declaration of those fields to be int instead of u32 and the code will
work as expected.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Stefan Roese <stefan.roese@mailbox.org>
drivers/phy/marvell/comphy_core.h