packet: only test po->has_vnet_hdr once in packet_snd
authorWillem de Bruijn <willemb@google.com>
Tue, 26 Sep 2017 16:20:17 +0000 (12:20 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 1 Jan 2018 20:50:53 +0000 (20:50 +0000)
commit2d8da6748e80b542ac58fca51deb0d4f42f2d54c
treed5bc96e3ffc259f4182a176e489baf5679c97fa0
parenta1a563d82bf0660f626c5a56ea91190f1283b315
packet: only test po->has_vnet_hdr once in packet_snd

commit da7c9561015e93d10fe6aab73e9288e0d09d65a6 upstream.

Packet socket option po->has_vnet_hdr can be updated concurrently with
other operations if no ring is attached.

Do not test the option twice in packet_snd, as the value may change in
between calls. A race on setsockopt disable may cause a packet > mtu
to be sent without having GSO options set.

Fixes: bfd5f4a3d605 ("packet: Add GSO/csum offload support.")
Signed-off-by: Willem de Bruijn <willemb@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/packet/af_packet.c