ext4: fix overflow when updating superblock backups after resize
authorJan Kara <jack@suse.cz>
Thu, 30 Oct 2014 14:52:57 +0000 (10:52 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Sun, 14 Dec 2014 16:23:53 +0000 (16:23 +0000)
commit2bd34f24f5db5997268f779c42a8dca20514a6f7
treefb004b953690caad22aeaf74e42ddc1dafa7c587
parent4dedbafc479dd5b5454f1be6468d4fc1a6c5c269
ext4: fix overflow when updating superblock backups after resize

commit 9378c6768e4fca48971e7b6a9075bc006eda981d upstream.

When there are no meta block groups update_backups() will compute the
backup block in 32-bit arithmetics thus possibly overflowing the block
number and corrupting the filesystem. OTOH filesystems without meta
block groups larger than 16 TB should be rare. Fix the problem by doing
the counting in 64-bit arithmetics.

Coverity-id: 741252
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/ext4/resize.c