hostap_cs: fix sleeping function called from invalid context
authorStanislaw Gruszka <sgruszka@redhat.com>
Mon, 10 Jan 2011 11:56:05 +0000 (12:56 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 17 Feb 2011 23:14:52 +0000 (15:14 -0800)
commit2636e659162bef783dc21d5cec6f7e06475a08e6
treea9a890f06e317036302d83b176e655abae291b97
parentdb5ae97dd4056b2f0cfbcb80488ce7f89981341a
hostap_cs: fix sleeping function called from invalid context

commit 4e5518ca53be29c1ec3c00089c97bef36bfed515 upstream.

pcmcia_request_irq() and pcmcia_enable_device() are intended
to be called from process context (first function allocate memory
with GFP_KERNEL, second take a mutex). We can not take spin lock
and call them.

It's safe to move spin lock after pcmcia_enable_device() as we
still hold off IRQ until dev->base_addr is 0 and driver will
not proceed with interrupts when is not ready.

Patch resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=643758

Reported-and-tested-by: rbugz@biobind.com
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/wireless/hostap/hostap_cs.c