powerpc/xmon: Fix data-breakpoint
authorRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Tue, 22 Nov 2016 09:25:59 +0000 (14:55 +0530)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 5 Jun 2017 20:13:49 +0000 (21:13 +0100)
commit249207e4f46d4a491228e8655a3433946c54ba2a
tree1df6dd438582ccc5cce6434852d35349ad5eb10b
parentbe1fba0a20485d78d98a2642f2cf658e09502736
powerpc/xmon: Fix data-breakpoint

commit c21a493a2b44650707d06741601894329486f2ad upstream.

Currently xmon data-breakpoint feature is broken.

Whenever there is a watchpoint match occurs, hw_breakpoint_handler will
be called by do_break via notifier chains mechanism. If watchpoint is
registered by xmon, hw_breakpoint_handler won't find any associated
perf_event and returns immediately with NOTIFY_STOP. Similarly, do_break
also returns without notifying to xmon.

Solve this by returning NOTIFY_DONE when hw_breakpoint_handler does not
find any perf_event associated with matched watchpoint, rather than
NOTIFY_STOP, which tells the core code to continue calling the other
breakpoint handlers including the xmon one.

Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/powerpc/kernel/hw_breakpoint.c