ALSA: aloop - add locking to timer access
authorOmair Mohammed Abdullah <omair.m.abdullah@linux.intel.com>
Sat, 29 Sep 2012 06:54:05 +0000 (12:24 +0530)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 17 Oct 2012 02:49:42 +0000 (03:49 +0100)
commit1fd7e28a2d9dec2c758bf43b92b1613dd22161d6
tree8f3d0e78da1c2deb78b72ce99ec8c60474f685c9
parent7737238648b535686434fdb1717b10d4c4f7c6d8
ALSA: aloop - add locking to timer access

commit d4f1e48bd11e3df6a26811f7a1f06c4225d92f7d upstream.

When the loopback timer handler is running, calling del_timer() (for STOP
trigger) will not wait for the handler to complete before deactivating the
timer. The timer gets rescheduled in the handler as usual. Then a subsequent
START trigger will try to start the timer using add_timer() with a timer pending
leading to a kernel panic.

Serialize the calls to add_timer() and del_timer() using a spin lock to avoid
this.

Signed-off-by: Omair Mohammed Abdullah <omair.m.abdullah@linux.intel.com>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/drivers/aloop.c