ext4: replace open coded nofail allocation in ext4_free_blocks()
authorMichal Hocko <mhocko@suse.cz>
Sun, 5 Jul 2015 16:33:44 +0000 (12:33 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 12 Aug 2015 14:33:19 +0000 (16:33 +0200)
commit1de7ce2b94fd02cba8e2fb0b2b6f341c5f920ce3
tree32b6393ed5e3f1e46d815822206ac03a72adf552
parentc45a8130fdee875c9d7b25ba50864aae1a1dafa3
ext4: replace open coded nofail allocation in ext4_free_blocks()

commit 7444a072c387a93ebee7066e8aee776954ab0e41 upstream.

ext4_free_blocks is looping around the allocation request and mimics
__GFP_NOFAIL behavior without any allocation fallback strategy. Let's
remove the open coded loop and replace it with __GFP_NOFAIL. Without the
flag the allocator has no way to find out never-fail requirement and
cannot help in any way.

Signed-off-by: Michal Hocko <mhocko@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
[bwh: Backported to 3.2:
 - Adjust context
 - s/ext4_free_data_cachep/ext4_free_ext_cachep/]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/ext4/mballoc.c