target: Fix SPC-2 RELEASE bug for multi-session iSCSI client setups
authorBernhard Kohl <Riedel-und-Kohl@t-online.de>
Sun, 13 May 2012 21:39:37 +0000 (23:39 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Sun, 20 May 2012 21:56:47 +0000 (22:56 +0100)
commit1601be1f76779ab23b7d04f86a231ede6bd90edc
treeeffe16fd6b492bbfe171d3ab81ff41bd06b545f1
parentf5dd890ef7c905ac61c3d3be1569df06849f74a3
target: Fix SPC-2 RELEASE bug for multi-session iSCSI client setups

commit edc318d9fea6854df752ec8c645b960b0d5a1d23 upstream.

This patch addresses a bug in a special case for target core SPC-2 RELEASE
logic where the same physical client (eg: iSCSI InitiatorName) with
differing iSCSI session identifiers (ISID) is allowed to incorrectly release
the same client's SPC-2 reservation from the non reservation holding path.

Note this bug is specific to iscsi-target w/ SPC-2 reservations, and
with the default enforce_pr_isids=1 device attr setting in target-core
controls if a InitiatorName + different ISID reservations are handled
the same as a single iSCSI client entity.

Signed-off-by: Bernhard Kohl <bernhard.kohl@gmx.net>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/target/target_core_pr.c