fuse: verify all ioctl retry iov elements
authorZach Brown <zab@redhat.com>
Tue, 24 Jul 2012 19:10:11 +0000 (12:10 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 12 Sep 2012 02:36:51 +0000 (03:36 +0100)
commit14269c277963f682ee99b8bff23816f8e07390d2
tree1cb49402b2e0361add2870c18995d1be605e057b
parent11306f0a62f8c12b0fa4a35d0b4dc5a91fa79612
fuse: verify all ioctl retry iov elements

commit fb6ccff667712c46b4501b920ea73a326e49626a upstream.

Commit 7572777eef78ebdee1ecb7c258c0ef94d35bad16 attempted to verify that
the total iovec from the client doesn't overflow iov_length() but it
only checked the first element.  The iovec could still overflow by
starting with a small element.  The obvious fix is to check all the
elements.

The overflow case doesn't look dangerous to the kernel as the copy is
limited by the length after the overflow.  This fix restores the
intention of returning an error instead of successfully copying less
than the iovec represented.

I found this by code inspection.  I built it but don't have a test case.
I'm cc:ing stable because the initial commit did as well.

Signed-off-by: Zach Brown <zab@redhat.com>
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/fuse/file.c