reiserfs: preserve i_mode if __reiserfs_set_acl() fails
authorErnesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
Mon, 17 Jul 2017 16:42:41 +0000 (18:42 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 12 Oct 2017 14:27:18 +0000 (15:27 +0100)
commit0f3bdf54a5def3706298bc4e741fb78690af6572
tree2d033d7d5a0017efee29ca9a4880521e58a9c653
parent96636fca5217f16f2ca93c5e2b816177d8930555
reiserfs: preserve i_mode if __reiserfs_set_acl() fails

commit fcea8aed91f53b51f9b943dc01f12d8aa666c720 upstream.

When changing a file's acl mask, reiserfs_set_acl() will first set the
group bits of i_mode to the value of the mask, and only then set the
actual extended attribute representing the new acl.

If the second part fails (due to lack of space, for example) and the
file had no acl attribute to begin with, the system will from now on
assume that the mask permission bits are actual group permission bits,
potentially granting access to the wrong users.

Prevent this by only changing the inode mode after the acl has been set.

Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/reiserfs/xattr_acl.c