KVM: x86: SYSENTER emulation is broken
authorNadav Amit <namit@cs.technion.ac.il>
Thu, 1 Jan 2015 21:11:11 +0000 (23:11 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 20 Feb 2015 00:49:42 +0000 (00:49 +0000)
commit038911f3d317d331d9637531c13710b8435fe96e
treee87f69008a54245155866f9c1992a61d6522aec6
parentd5616c083eb60afce45e44fb0f790aa7b9f20656
KVM: x86: SYSENTER emulation is broken

commit f3747379accba8e95d70cec0eae0582c8c182050 upstream.

SYSENTER emulation is broken in several ways:
1. It misses the case of 16-bit code segments completely (CVE-2015-0239).
2. MSR_IA32_SYSENTER_CS is checked in 64-bit mode incorrectly (bits 0 and 1 can
   still be set without causing #GP).
3. MSR_IA32_SYSENTER_EIP and MSR_IA32_SYSENTER_ESP are not masked in
   legacy-mode.
4. There is some unneeded code.

Fix it.

Cc: stable@vger.linux.org
Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/x86/kvm/emulate.c