can: sja1000: clear interrupts on start
authorMirza Krak <mirza.krak@hostmobility.com>
Tue, 10 Nov 2015 13:59:34 +0000 (14:59 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 30 Dec 2015 02:25:57 +0000 (02:25 +0000)
commit020c29c1f9d4b98562b91892935e9a9e2ee5d3aa
treeee5cb7ad5026050267c69a67897655176b2cb47d
parent611da32f948f22d20208891bbf08ceea70d3086e
can: sja1000: clear interrupts on start

commit 7cecd9ab80f43972c056dc068338f7bcc407b71c upstream.

According to SJA1000 data sheet error-warning (EI) interrupt is not
cleared by setting the controller in to reset-mode.

Then if we have the following case:
- system is suspended (echo mem > /sys/power/state) and SJA1000 is left
  in operating state
- A bus error condition occurs which activates EI interrupt, system is
  still suspended which means EI interrupt will be not be handled nor
  cleared.

If the above two events occur, on resume there is no way to return the
SJA1000 to operating state, except to cycle power to it.

By simply reading the IR register on start we will clear any previous
conditions that could be present.

Signed-off-by: Mirza Krak <mirza.krak@hostmobility.com>
Reported-by: Christian Magnusson <Christian.Magnusson@semcon.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
[bwh: Backported to 3.2: s/SJA1000_IR/REG_IR/]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/can/sja1000/sja1000.c