fbdev: color map copying bounds checking
authorKees Cook <keescook@chromium.org>
Tue, 24 Jan 2017 23:18:24 +0000 (15:18 -0800)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 23 Feb 2017 03:51:05 +0000 (03:51 +0000)
commit00a188b0e63feb83d7e78a91dee6f621a0dcbdda
tree35d7fba7fdcd260814ae44b69070a536846988fc
parent119e11a50fc0e5218e0a0f2d7d87c0cbf1d54940
fbdev: color map copying bounds checking

commit 2dc705a9930b4806250fbf5a76e55266e59389f2 upstream.

Copying color maps to userspace doesn't check the value of to->start,
which will cause kernel heap buffer OOB read due to signedness wraps.

CVE-2016-8405

Link: http://lkml.kernel.org/r/20170105224249.GA50925@beast
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kees Cook <keescook@chromium.org>
Reported-by: Peter Pi (@heisecode) of Trend Micro
Cc: Min Chong <mchong@google.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/video/fbcmap.c