git.openpandora.org
/
pandora-libraries.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
| inline |
side by side
Bloody off-by-1 error for a malloc, leading to ever-so-slight memory corruption....
[pandora-libraries.git]
/
lib
/
pnd_pxml.c
diff --git
a/lib/pnd_pxml.c
b/lib/pnd_pxml.c
index
4b743d4
..
934c75c
100644
(file)
--- a/
lib/pnd_pxml.c
+++ b/
lib/pnd_pxml.c
@@
-29,7
+29,11
@@
pnd_pxml_handle *pnd_pxml_fetch ( char *fullpath ) {
fseek ( f, 0, SEEK_SET );
- b = (char*) malloc ( len );
+ if ( ! len ) {
+ return ( NULL );
+ }
+
+ b = (char*) malloc ( len + 1 );
if ( ! b ) {
fclose ( f );