md/raid0: typedef removal: raid0_conf_t -> struct r0conf
[pandora-kernel.git] / drivers / md / raid10.c
index 8b29cd4..39661b1 100644 (file)
@@ -64,7 +64,7 @@ static void lower_barrier(conf_t *conf);
 static void * r10bio_pool_alloc(gfp_t gfp_flags, void *data)
 {
        conf_t *conf = data;
-       int size = offsetof(struct r10bio_s, devs[conf->copies]);
+       int size = offsetof(struct r10bio, devs[conf->copies]);
 
        /* allocate a r10bio with room for raid_disks entries in the bios array */
        return kzalloc(size, gfp_flags);
@@ -94,7 +94,7 @@ static void * r10buf_pool_alloc(gfp_t gfp_flags, void *data)
 {
        conf_t *conf = data;
        struct page *page;
-       r10bio_t *r10_bio;
+       struct r10bio *r10_bio;
        struct bio *bio;
        int i, j;
        int nalloc;
@@ -159,7 +159,7 @@ static void r10buf_pool_free(void *__r10_bio, void *data)
 {
        int i;
        conf_t *conf = data;
-       r10bio_t *r10bio = __r10_bio;
+       struct r10bio *r10bio = __r10_bio;
        int j;
 
        for (j=0; j < conf->copies; j++) {
@@ -175,7 +175,7 @@ static void r10buf_pool_free(void *__r10_bio, void *data)
        r10bio_pool_free(r10bio, conf);
 }
 
-static void put_all_bios(conf_t *conf, r10bio_t *r10_bio)
+static void put_all_bios(conf_t *conf, struct r10bio *r10_bio)
 {
        int i;
 
@@ -187,7 +187,7 @@ static void put_all_bios(conf_t *conf, r10bio_t *r10_bio)
        }
 }
 
-static void free_r10bio(r10bio_t *r10_bio)
+static void free_r10bio(struct r10bio *r10_bio)
 {
        conf_t *conf = r10_bio->mddev->private;
 
@@ -195,7 +195,7 @@ static void free_r10bio(r10bio_t *r10_bio)
        mempool_free(r10_bio, conf->r10bio_pool);
 }
 
-static void put_buf(r10bio_t *r10_bio)
+static void put_buf(struct r10bio *r10_bio)
 {
        conf_t *conf = r10_bio->mddev->private;
 
@@ -204,10 +204,10 @@ static void put_buf(r10bio_t *r10_bio)
        lower_barrier(conf);
 }
 
-static void reschedule_retry(r10bio_t *r10_bio)
+static void reschedule_retry(struct r10bio *r10_bio)
 {
        unsigned long flags;
-       mddev_t *mddev = r10_bio->mddev;
+       struct mddev *mddev = r10_bio->mddev;
        conf_t *conf = mddev->private;
 
        spin_lock_irqsave(&conf->device_lock, flags);
@@ -226,7 +226,7 @@ static void reschedule_retry(r10bio_t *r10_bio)
  * operation and are ready to return a success/failure code to the buffer
  * cache layer.
  */
-static void raid_end_bio_io(r10bio_t *r10_bio)
+static void raid_end_bio_io(struct r10bio *r10_bio)
 {
        struct bio *bio = r10_bio->master_bio;
        int done;
@@ -256,7 +256,7 @@ static void raid_end_bio_io(r10bio_t *r10_bio)
 /*
  * Update disk head position estimator based on IRQ completion info.
  */
-static inline void update_head_pos(int slot, r10bio_t *r10_bio)
+static inline void update_head_pos(int slot, struct r10bio *r10_bio)
 {
        conf_t *conf = r10_bio->mddev->private;
 
@@ -267,7 +267,7 @@ static inline void update_head_pos(int slot, r10bio_t *r10_bio)
 /*
  * Find the disk number which triggered given bio
  */
-static int find_bio_disk(conf_t *conf, r10bio_t *r10_bio,
+static int find_bio_disk(conf_t *conf, struct r10bio *r10_bio,
                         struct bio *bio, int *slotp)
 {
        int slot;
@@ -287,7 +287,7 @@ static int find_bio_disk(conf_t *conf, r10bio_t *r10_bio,
 static void raid10_end_read_request(struct bio *bio, int error)
 {
        int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags);
-       r10bio_t *r10_bio = bio->bi_private;
+       struct r10bio *r10_bio = bio->bi_private;
        int slot, dev;
        conf_t *conf = r10_bio->mddev->private;
 
@@ -327,7 +327,7 @@ static void raid10_end_read_request(struct bio *bio, int error)
        }
 }
 
-static void close_write(r10bio_t *r10_bio)
+static void close_write(struct r10bio *r10_bio)
 {
        /* clear the bitmap if all writes complete successfully */
        bitmap_endwrite(r10_bio->mddev->bitmap, r10_bio->sector,
@@ -337,10 +337,25 @@ static void close_write(r10bio_t *r10_bio)
        md_write_end(r10_bio->mddev);
 }
 
+static void one_write_done(struct r10bio *r10_bio)
+{
+       if (atomic_dec_and_test(&r10_bio->remaining)) {
+               if (test_bit(R10BIO_WriteError, &r10_bio->state))
+                       reschedule_retry(r10_bio);
+               else {
+                       close_write(r10_bio);
+                       if (test_bit(R10BIO_MadeGood, &r10_bio->state))
+                               reschedule_retry(r10_bio);
+                       else
+                               raid_end_bio_io(r10_bio);
+               }
+       }
+}
+
 static void raid10_end_write_request(struct bio *bio, int error)
 {
        int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags);
-       r10bio_t *r10_bio = bio->bi_private;
+       struct r10bio *r10_bio = bio->bi_private;
        int dev;
        int dec_rdev = 1;
        conf_t *conf = r10_bio->mddev->private;
@@ -387,17 +402,7 @@ static void raid10_end_write_request(struct bio *bio, int error)
         * Let's see if all mirrored write operations have finished
         * already.
         */
-       if (atomic_dec_and_test(&r10_bio->remaining)) {
-               if (test_bit(R10BIO_WriteError, &r10_bio->state))
-                       reschedule_retry(r10_bio);
-               else {
-                       close_write(r10_bio);
-                       if (test_bit(R10BIO_MadeGood, &r10_bio->state))
-                               reschedule_retry(r10_bio);
-                       else
-                               raid_end_bio_io(r10_bio);
-               }
-       }
+       one_write_done(r10_bio);
        if (dec_rdev)
                rdev_dec_pending(conf->mirrors[dev].rdev, conf->mddev);
 }
@@ -428,7 +433,7 @@ static void raid10_end_write_request(struct bio *bio, int error)
  * sector offset to a virtual address
  */
 
-static void raid10_find_phys(conf_t *conf, r10bio_t *r10bio)
+static void raid10_find_phys(conf_t *conf, struct r10bio *r10bio)
 {
        int n,f;
        sector_t sector;
@@ -517,7 +522,7 @@ static int raid10_mergeable_bvec(struct request_queue *q,
                                 struct bvec_merge_data *bvm,
                                 struct bio_vec *biovec)
 {
-       mddev_t *mddev = q->queuedata;
+       struct mddev *mddev = q->queuedata;
        sector_t sector = bvm->bi_sector + get_start_sect(bvm->bi_bdev);
        int max;
        unsigned int chunk_sectors = mddev->chunk_sectors;
@@ -550,14 +555,14 @@ static int raid10_mergeable_bvec(struct request_queue *q,
  * FIXME: possibly should rethink readbalancing and do it differently
  * depending on near_copies / far_copies geometry.
  */
-static int read_balance(conf_t *conf, r10bio_t *r10_bio, int *max_sectors)
+static int read_balance(conf_t *conf, struct r10bio *r10_bio, int *max_sectors)
 {
        const sector_t this_sector = r10_bio->sector;
        int disk, slot;
        int sectors = r10_bio->sectors;
        int best_good_sectors;
        sector_t new_distance, best_dist;
-       mdk_rdev_t *rdev;
+       struct md_rdev *rdev;
        int do_balance;
        int best_slot;
 
@@ -672,7 +677,7 @@ retry:
 
 static int raid10_congested(void *data, int bits)
 {
-       mddev_t *mddev = data;
+       struct mddev *mddev = data;
        conf_t *conf = mddev->private;
        int i, ret = 0;
 
@@ -680,7 +685,7 @@ static int raid10_congested(void *data, int bits)
                return 1;
        rcu_read_lock();
        for (i = 0; i < conf->raid_disks && ret == 0; i++) {
-               mdk_rdev_t *rdev = rcu_dereference(conf->mirrors[i].rdev);
+               struct md_rdev *rdev = rcu_dereference(conf->mirrors[i].rdev);
                if (rdev && !test_bit(Faulty, &rdev->flags)) {
                        struct request_queue *q = bdev_get_queue(rdev->bdev);
 
@@ -825,11 +830,11 @@ static void unfreeze_array(conf_t *conf)
        spin_unlock_irq(&conf->resync_lock);
 }
 
-static int make_request(mddev_t *mddev, struct bio * bio)
+static int make_request(struct mddev *mddev, struct bio * bio)
 {
        conf_t *conf = mddev->private;
-       mirror_info_t *mirror;
-       r10bio_t *r10_bio;
+       struct mirror_info *mirror;
+       struct r10bio *r10_bio;
        struct bio *read_bio;
        int i;
        int chunk_sects = conf->chunk_mask + 1;
@@ -837,7 +842,7 @@ static int make_request(mddev_t *mddev, struct bio * bio)
        const unsigned long do_sync = (bio->bi_rw & REQ_SYNC);
        const unsigned long do_fua = (bio->bi_rw & REQ_FUA);
        unsigned long flags;
-       mdk_rdev_t *blocked_rdev;
+       struct md_rdev *blocked_rdev;
        int plugged;
        int sectors_handled;
        int max_sectors;
@@ -1012,7 +1017,7 @@ retry_write:
 
        for (i = 0;  i < conf->copies; i++) {
                int d = r10_bio->devs[i].devnum;
-               mdk_rdev_t *rdev = rcu_dereference(conf->mirrors[d].rdev);
+               struct md_rdev *rdev = rcu_dereference(conf->mirrors[d].rdev);
                if (rdev && unlikely(test_bit(Blocked, &rdev->flags))) {
                        atomic_inc(&rdev->nr_pending);
                        blocked_rdev = rdev;
@@ -1127,20 +1132,12 @@ retry_write:
                spin_unlock_irqrestore(&conf->device_lock, flags);
        }
 
-       if (atomic_dec_and_test(&r10_bio->remaining)) {
-               /* This matches the end of raid10_end_write_request() */
-               bitmap_endwrite(r10_bio->mddev->bitmap, r10_bio->sector,
-                               r10_bio->sectors,
-                               !test_bit(R10BIO_Degraded, &r10_bio->state),
-                               0);
-               md_write_end(mddev);
-               raid_end_bio_io(r10_bio);
-       }
-
-       /* In case raid10d snuck in to freeze_array */
-       wake_up(&conf->wait_barrier);
+       /* Don't remove the bias on 'remaining' (one_write_done) until
+        * after checking if we need to go around again.
+        */
 
        if (sectors_handled < (bio->bi_size >> 9)) {
+               one_write_done(r10_bio);
                /* We need another r10_bio.  It has already been counted
                 * in bio->bi_phys_segments.
                 */
@@ -1154,13 +1151,17 @@ retry_write:
                r10_bio->state = 0;
                goto retry_write;
        }
+       one_write_done(r10_bio);
+
+       /* In case raid10d snuck in to freeze_array */
+       wake_up(&conf->wait_barrier);
 
        if (do_sync || !mddev->bitmap || !plugged)
                md_wakeup_thread(mddev->thread);
        return 0;
 }
 
-static void status(struct seq_file *seq, mddev_t *mddev)
+static void status(struct seq_file *seq, struct mddev *mddev)
 {
        conf_t *conf = mddev->private;
        int i;
@@ -1208,7 +1209,7 @@ static int enough(conf_t *conf, int ignore)
        return 1;
 }
 
-static void error(mddev_t *mddev, mdk_rdev_t *rdev)
+static void error(struct mddev *mddev, struct md_rdev *rdev)
 {
        char b[BDEVNAME_SIZE];
        conf_t *conf = mddev->private;
@@ -1248,7 +1249,7 @@ static void error(mddev_t *mddev, mdk_rdev_t *rdev)
 static void print_conf(conf_t *conf)
 {
        int i;
-       mirror_info_t *tmp;
+       struct mirror_info *tmp;
 
        printk(KERN_DEBUG "RAID10 conf printout:\n");
        if (!conf) {
@@ -1278,11 +1279,11 @@ static void close_sync(conf_t *conf)
        conf->r10buf_pool = NULL;
 }
 
-static int raid10_spare_active(mddev_t *mddev)
+static int raid10_spare_active(struct mddev *mddev)
 {
        int i;
        conf_t *conf = mddev->private;
-       mirror_info_t *tmp;
+       struct mirror_info *tmp;
        int count = 0;
        unsigned long flags;
 
@@ -1308,7 +1309,7 @@ static int raid10_spare_active(mddev_t *mddev)
 }
 
 
-static int raid10_add_disk(mddev_t *mddev, mdk_rdev_t *rdev)
+static int raid10_add_disk(struct mddev *mddev, struct md_rdev *rdev)
 {
        conf_t *conf = mddev->private;
        int err = -EEXIST;
@@ -1333,7 +1334,7 @@ static int raid10_add_disk(mddev_t *mddev, mdk_rdev_t *rdev)
        else
                mirror = first;
        for ( ; mirror <= last ; mirror++) {
-               mirror_info_t *p = &conf->mirrors[mirror];
+               struct mirror_info *p = &conf->mirrors[mirror];
                if (p->recovery_disabled == mddev->recovery_disabled)
                        continue;
                if (!p->rdev)
@@ -1367,12 +1368,12 @@ static int raid10_add_disk(mddev_t *mddev, mdk_rdev_t *rdev)
        return err;
 }
 
-static int raid10_remove_disk(mddev_t *mddev, int number)
+static int raid10_remove_disk(struct mddev *mddev, int number)
 {
        conf_t *conf = mddev->private;
        int err = 0;
-       mdk_rdev_t *rdev;
-       mirror_info_t *p = conf->mirrors+ number;
+       struct md_rdev *rdev;
+       struct mirror_info *p = conf->mirrors+ number;
 
        print_conf(conf);
        rdev = p->rdev;
@@ -1410,7 +1411,7 @@ abort:
 
 static void end_sync_read(struct bio *bio, int error)
 {
-       r10bio_t *r10_bio = bio->bi_private;
+       struct r10bio *r10_bio = bio->bi_private;
        conf_t *conf = r10_bio->mddev->private;
        int d;
 
@@ -1438,9 +1439,9 @@ static void end_sync_read(struct bio *bio, int error)
        }
 }
 
-static void end_sync_request(r10bio_t *r10_bio)
+static void end_sync_request(struct r10bio *r10_bio)
 {
-       mddev_t *mddev = r10_bio->mddev;
+       struct mddev *mddev = r10_bio->mddev;
 
        while (atomic_dec_and_test(&r10_bio->remaining)) {
                if (r10_bio->master_bio == NULL) {
@@ -1454,7 +1455,7 @@ static void end_sync_request(r10bio_t *r10_bio)
                        md_done_sync(mddev, s, 1);
                        break;
                } else {
-                       r10bio_t *r10_bio2 = (r10bio_t *)r10_bio->master_bio;
+                       struct r10bio *r10_bio2 = (struct r10bio *)r10_bio->master_bio;
                        if (test_bit(R10BIO_MadeGood, &r10_bio->state) ||
                            test_bit(R10BIO_WriteError, &r10_bio->state))
                                reschedule_retry(r10_bio);
@@ -1468,8 +1469,8 @@ static void end_sync_request(r10bio_t *r10_bio)
 static void end_sync_write(struct bio *bio, int error)
 {
        int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags);
-       r10bio_t *r10_bio = bio->bi_private;
-       mddev_t *mddev = r10_bio->mddev;
+       struct r10bio *r10_bio = bio->bi_private;
+       struct mddev *mddev = r10_bio->mddev;
        conf_t *conf = mddev->private;
        int d;
        sector_t first_bad;
@@ -1508,7 +1509,7 @@ static void end_sync_write(struct bio *bio, int error)
  * We check if all blocks are in-sync and only write to blocks that
  * aren't in sync
  */
-static void sync_request_write(mddev_t *mddev, r10bio_t *r10_bio)
+static void sync_request_write(struct mddev *mddev, struct r10bio *r10_bio)
 {
        conf_t *conf = mddev->private;
        int i, first;
@@ -1608,7 +1609,7 @@ done:
  * The second for writing.
  *
  */
-static void fix_recovery_read_error(r10bio_t *r10_bio)
+static void fix_recovery_read_error(struct r10bio *r10_bio)
 {
        /* We got a read error during recovery.
         * We repeat the read in smaller page-sized sections.
@@ -1617,7 +1618,7 @@ static void fix_recovery_read_error(r10bio_t *r10_bio)
         * If a read fails, record a bad block on both old and
         * new devices.
         */
-       mddev_t *mddev = r10_bio->mddev;
+       struct mddev *mddev = r10_bio->mddev;
        conf_t *conf = mddev->private;
        struct bio *bio = r10_bio->devs[0].bio;
        sector_t sect = 0;
@@ -1628,7 +1629,7 @@ static void fix_recovery_read_error(r10bio_t *r10_bio)
 
        while (sectors) {
                int s = sectors;
-               mdk_rdev_t *rdev;
+               struct md_rdev *rdev;
                sector_t addr;
                int ok;
 
@@ -1662,7 +1663,7 @@ static void fix_recovery_read_error(r10bio_t *r10_bio)
 
                        if (rdev != conf->mirrors[dw].rdev) {
                                /* need bad block on destination too */
-                               mdk_rdev_t *rdev2 = conf->mirrors[dw].rdev;
+                               struct md_rdev *rdev2 = conf->mirrors[dw].rdev;
                                addr = r10_bio->devs[1].addr + sect;
                                ok = rdev_set_badblocks(rdev2, addr, s, 0);
                                if (!ok) {
@@ -1687,7 +1688,7 @@ static void fix_recovery_read_error(r10bio_t *r10_bio)
        }
 }
 
-static void recovery_request_write(mddev_t *mddev, r10bio_t *r10_bio)
+static void recovery_request_write(struct mddev *mddev, struct r10bio *r10_bio)
 {
        conf_t *conf = mddev->private;
        int d;
@@ -1718,7 +1719,7 @@ static void recovery_request_write(mddev_t *mddev, r10bio_t *r10_bio)
  * since the last recorded read error.
  *
  */
-static void check_decay_read_errors(mddev_t *mddev, mdk_rdev_t *rdev)
+static void check_decay_read_errors(struct mddev *mddev, struct md_rdev *rdev)
 {
        struct timespec cur_time_mon;
        unsigned long hours_since_last;
@@ -1749,7 +1750,7 @@ static void check_decay_read_errors(mddev_t *mddev, mdk_rdev_t *rdev)
                atomic_set(&rdev->read_errors, read_errors >> hours_since_last);
 }
 
-static int r10_sync_page_io(mdk_rdev_t *rdev, sector_t sector,
+static int r10_sync_page_io(struct md_rdev *rdev, sector_t sector,
                            int sectors, struct page *page, int rw)
 {
        sector_t first_bad;
@@ -1777,11 +1778,11 @@ static int r10_sync_page_io(mdk_rdev_t *rdev, sector_t sector,
  *     3.      Performs writes following reads for array synchronising.
  */
 
-static void fix_read_error(conf_t *conf, mddev_t *mddev, r10bio_t *r10_bio)
+static void fix_read_error(conf_t *conf, struct mddev *mddev, struct r10bio *r10_bio)
 {
        int sect = 0; /* Offset from r10_bio->sector */
        int sectors = r10_bio->sectors;
-       mdk_rdev_t*rdev;
+       struct md_rdev*rdev;
        int max_read_errors = atomic_read(&mddev->max_corr_read_errors);
        int d = r10_bio->devs[r10_bio->read_slot].devnum;
 
@@ -1982,12 +1983,12 @@ static int submit_bio_wait(int rw, struct bio *bio)
        return test_bit(BIO_UPTODATE, &bio->bi_flags);
 }
 
-static int narrow_write_error(r10bio_t *r10_bio, int i)
+static int narrow_write_error(struct r10bio *r10_bio, int i)
 {
        struct bio *bio = r10_bio->master_bio;
-       mddev_t *mddev = r10_bio->mddev;
+       struct mddev *mddev = r10_bio->mddev;
        conf_t *conf = mddev->private;
-       mdk_rdev_t *rdev = conf->mirrors[r10_bio->devs[i].devnum].rdev;
+       struct md_rdev *rdev = conf->mirrors[r10_bio->devs[i].devnum].rdev;
        /* bio has the data to be written to slot 'i' where
         * we just recently had a write error.
         * We repeatedly clone the bio and trim down to one block,
@@ -2039,13 +2040,13 @@ static int narrow_write_error(r10bio_t *r10_bio, int i)
        return ok;
 }
 
-static void handle_read_error(mddev_t *mddev, r10bio_t *r10_bio)
+static void handle_read_error(struct mddev *mddev, struct r10bio *r10_bio)
 {
        int slot = r10_bio->read_slot;
        int mirror = r10_bio->devs[slot].devnum;
        struct bio *bio;
        conf_t *conf = mddev->private;
-       mdk_rdev_t *rdev;
+       struct md_rdev *rdev;
        char b[BDEVNAME_SIZE];
        unsigned long do_sync;
        int max_sectors;
@@ -2138,7 +2139,7 @@ read_more:
                generic_make_request(bio);
 }
 
-static void handle_write_completed(conf_t *conf, r10bio_t *r10_bio)
+static void handle_write_completed(conf_t *conf, struct r10bio *r10_bio)
 {
        /* Some sort of write request has finished and it
         * succeeded in writing where we thought there was a
@@ -2147,7 +2148,7 @@ static void handle_write_completed(conf_t *conf, r10bio_t *r10_bio)
         * a bad block.
         */
        int m;
-       mdk_rdev_t *rdev;
+       struct md_rdev *rdev;
 
        if (test_bit(R10BIO_IsSync, &r10_bio->state) ||
            test_bit(R10BIO_IsRecover, &r10_bio->state)) {
@@ -2199,9 +2200,9 @@ static void handle_write_completed(conf_t *conf, r10bio_t *r10_bio)
        }
 }
 
-static void raid10d(mddev_t *mddev)
+static void raid10d(struct mddev *mddev)
 {
-       r10bio_t *r10_bio;
+       struct r10bio *r10_bio;
        unsigned long flags;
        conf_t *conf = mddev->private;
        struct list_head *head = &conf->retry_list;
@@ -2219,7 +2220,7 @@ static void raid10d(mddev_t *mddev)
                        spin_unlock_irqrestore(&conf->device_lock, flags);
                        break;
                }
-               r10_bio = list_entry(head->prev, r10bio_t, retry_list);
+               r10_bio = list_entry(head->prev, struct r10bio, retry_list);
                list_del(head->prev);
                conf->nr_queued--;
                spin_unlock_irqrestore(&conf->device_lock, flags);
@@ -2296,11 +2297,11 @@ static int init_resync(conf_t *conf)
  *
  */
 
-static sector_t sync_request(mddev_t *mddev, sector_t sector_nr,
+static sector_t sync_request(struct mddev *mddev, sector_t sector_nr,
                             int *skipped, int go_faster)
 {
        conf_t *conf = mddev->private;
-       r10bio_t *r10_bio;
+       struct r10bio *r10_bio;
        struct bio *biolist = NULL, *bio;
        sector_t max_sector, nr_sectors;
        int i;
@@ -2392,7 +2393,7 @@ static sector_t sync_request(mddev_t *mddev, sector_t sector_nr,
 
                for (i=0 ; i<conf->raid_disks; i++) {
                        int still_degraded;
-                       r10bio_t *rb2;
+                       struct r10bio *rb2;
                        sector_t sect;
                        int must_sync;
                        int any_working;
@@ -2452,7 +2453,7 @@ static sector_t sync_request(mddev_t *mddev, sector_t sector_nr,
                                int k;
                                int d = r10_bio->devs[j].devnum;
                                sector_t from_addr, to_addr;
-                               mdk_rdev_t *rdev;
+                               struct md_rdev *rdev;
                                sector_t sector, first_bad;
                                int bad_sectors;
                                if (!conf->mirrors[d].rdev ||
@@ -2546,8 +2547,8 @@ static sector_t sync_request(mddev_t *mddev, sector_t sector_nr,
                }
                if (biolist == NULL) {
                        while (r10_bio) {
-                               r10bio_t *rb2 = r10_bio;
-                               r10_bio = (r10bio_t*) rb2->master_bio;
+                               struct r10bio *rb2 = r10_bio;
+                               r10_bio = (struct r10bio*) rb2->master_bio;
                                rb2->master_bio = NULL;
                                put_buf(rb2);
                        }
@@ -2713,7 +2714,7 @@ static sector_t sync_request(mddev_t *mddev, sector_t sector_nr,
 }
 
 static sector_t
-raid10_size(mddev_t *mddev, sector_t sectors, int raid_disks)
+raid10_size(struct mddev *mddev, sector_t sectors, int raid_disks)
 {
        sector_t size;
        conf_t *conf = mddev->private;
@@ -2732,7 +2733,7 @@ raid10_size(mddev_t *mddev, sector_t sectors, int raid_disks)
 }
 
 
-static conf_t *setup_conf(mddev_t *mddev)
+static conf_t *setup_conf(struct mddev *mddev)
 {
        conf_t *conf = NULL;
        int nc, fc, fo;
@@ -2835,12 +2836,12 @@ static conf_t *setup_conf(mddev_t *mddev)
        return ERR_PTR(err);
 }
 
-static int run(mddev_t *mddev)
+static int run(struct mddev *mddev)
 {
        conf_t *conf;
        int i, disk_idx, chunk_size;
-       mirror_info_t *disk;
-       mdk_rdev_t *rdev;
+       struct mirror_info *disk;
+       struct md_rdev *rdev;
        sector_t size;
 
        /*
@@ -2954,7 +2955,7 @@ static int run(mddev_t *mddev)
        return 0;
 
 out_free_conf:
-       md_unregister_thread(mddev->thread);
+       md_unregister_thread(&mddev->thread);
        if (conf->r10bio_pool)
                mempool_destroy(conf->r10bio_pool);
        safe_put_page(conf->tmppage);
@@ -2965,15 +2966,14 @@ out:
        return -EIO;
 }
 
-static int stop(mddev_t *mddev)
+static int stop(struct mddev *mddev)
 {
        conf_t *conf = mddev->private;
 
        raise_barrier(conf, 0);
        lower_barrier(conf);
 
-       md_unregister_thread(mddev->thread);
-       mddev->thread = NULL;
+       md_unregister_thread(&mddev->thread);
        blk_sync_queue(mddev->queue); /* the unplug fn references 'conf'*/
        if (conf->r10bio_pool)
                mempool_destroy(conf->r10bio_pool);
@@ -2983,7 +2983,7 @@ static int stop(mddev_t *mddev)
        return 0;
 }
 
-static void raid10_quiesce(mddev_t *mddev, int state)
+static void raid10_quiesce(struct mddev *mddev, int state)
 {
        conf_t *conf = mddev->private;
 
@@ -2997,9 +2997,9 @@ static void raid10_quiesce(mddev_t *mddev, int state)
        }
 }
 
-static void *raid10_takeover_raid0(mddev_t *mddev)
+static void *raid10_takeover_raid0(struct mddev *mddev)
 {
-       mdk_rdev_t *rdev;
+       struct md_rdev *rdev;
        conf_t *conf;
 
        if (mddev->degraded > 0) {
@@ -3029,17 +3029,17 @@ static void *raid10_takeover_raid0(mddev_t *mddev)
        return conf;
 }
 
-static void *raid10_takeover(mddev_t *mddev)
+static void *raid10_takeover(struct mddev *mddev)
 {
-       struct raid0_private_data *raid0_priv;
+       struct r0conf *raid0_conf;
 
        /* raid10 can take over:
         *  raid0 - providing it has only two drives
         */
        if (mddev->level == 0) {
                /* for raid0 takeover only one zone is supported */
-               raid0_priv = mddev->private;
-               if (raid0_priv->nr_strip_zones > 1) {
+               raid0_conf = mddev->private;
+               if (raid0_conf->nr_strip_zones > 1) {
                        printk(KERN_ERR "md/raid10:%s: cannot takeover raid 0"
                               " with more than one zone.\n",
                               mdname(mddev));