Pandora Sourcecodes - openembedded.git/blob

   1 From 4a5fc4e179d79c79ad87bfc12a2d7e9b2371e40c Mon Sep 17 00:00:00 2001
   2 From: Dan Carpenter <error27@gmail.com>
   3 Date: Thu, 23 Dec 2010 19:17:34 +0000
   4 Subject: [PATCH 16/66] skfp: testing the wrong variable in skfp_driver_init()
   5
   6 The intent here was to test if the allocation failed but we tested
   7 "SharedMemSize" instead of "SharedMemAddr" by mistake.
   8
   9 Signed-off-by: Dan Carpenter <error27@gmail.com>
  10 Reviewed-by: Jiri Pirko <jpirko@redhat.com>
  11 Signed-off-by: David S. Miller <davem@davemloft.net>
  12 ---
  13  drivers/net/skfp/skfddi.c |    2 +-
  14  1 files changed, 1 insertions(+), 1 deletions(-)
  15
  16 diff --git a/drivers/net/skfp/skfddi.c b/drivers/net/skfp/skfddi.c
  17 index 0a66fed..16c6265 100644
  18 --- a/drivers/net/skfp/skfddi.c
  19 +++ b/drivers/net/skfp/skfddi.c
  20 @@ -412,7 +412,7 @@ static  int skfp_driver_init(struct net_device *dev)
  21                 bp->SharedMemAddr = pci_alloc_consistent(&bp->pdev,
  22                                                          bp->SharedMemSize,
  23                                                          &bp->SharedMemDMA);
  24 -               if (!bp->SharedMemSize) {
  25 +               if (!bp->SharedMemAddr) {
  26                         printk("could not allocate mem for ");
  27                         printk("hardware module: %ld byte\n",
  28                                bp->SharedMemSize);
  29 --
  30 1.6.6.1
  31